78762[BUGFIX] Transparently add Link Browser classes to ckeditor
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1417
-
Andreas Kienast uploaded patch set 1 04/20/23, 09:36
-
core-ci voted on patch set 1 V +1 04/20/23, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40950
-
Stefan Froemken commented on patch set 1 04/24/23, 06:26
CKEditor5Migrator.php:707negate and early return. That way we can save one indent -
Stefan Froemken commented on patch set 1 04/24/23, 06:29
missing "is" -
Andreas Kienast commented on patch set 1 04/24/23, 06:30
Reply
AckCKEditor5Migrator.php:223ReplyWe can, but I wanted to change the absolute minimum necessary stuff only to keep the patch in a reviewable state.CKEditor5Migrator.php:707ReplyAck -
Andreas Kienast uploaded patch set 2
V +104/24/23, 06:32 -
core-ci voted on patch set 2 V +1 04/24/23, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41115
-
Stefan Froemken voted on patch set 2 CR +1 04/24/23, 07:28
-
Benni Mack commented on patch set 2 V +1 CR +1 04/24/23, 14:33
good solution -
Oli Bartsch voted on patch set 2 V +1 CR +1 04/24/23, 16:08
-
Oli Bartsch commented on patch set 2 V 0 CR -1 04/24/23, 16:17
On it -
Oli Bartsch uploaded patch set 3
CR +1V +104/24/23, 16:29 -
Oli Bartsch uploaded patch set 4 04/24/23, 16:31
-
core-ci voted on patch set 4 V +1 04/24/23, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41180
-
Benni Mack voted on patch set 4 V +1 CR +1 04/24/23, 18:40
-
Oli Bartsch commented on patch set 4 V +2 CR +2 04/24/23, 19:32
CKEditor5Migrator.php:223ReplyDone -
Oli Bartsch merged patch set 5 04/24/23, 19:32
CKEditor5Migrator.php:223