Review 11.5 Merged

78769[BUGFIX] `ceil()` dimensions in CropperEvent

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 04/20/23, 14:13

Commit message

The dimensions available in `CropperEvent` are fractions in some cases,
that probably happens when an image gets upscaled. This causes issues
as those dimensions are apparently adjusted downward in the cropper
library, resulting in dimension reduced by 1px. To solve this issue,
`Math.ceil()` is applied to round up incoming dimensions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 04/20/23, 13:57

  2. core-ci voted on patch set 1 V +1 04/20/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40975

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 04/20/23, 14:12

  4. Andreas Kienast merged patch set 2 04/20/23, 14:13