Review main Merged

78772[TASK] Add type declarations for GU::fixWindowsFilePath

Oliver Klee CR +2 V +2 Easy +14 −17 updated 04/20/23, 15:38

Commit message

Also add casts to callers that are not type-safe (yet).

Also convert one call to use a first-class callable to improve
static analysis.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 56

  1. Oliver Klee uploaded patch set 1 04/20/23, 14:36

  2. core-ci voted on patch set 1 V +1 04/20/23, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40980

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 04/20/23, 15:21

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 04/20/23, 15:38

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/20/23, 15:38

  6. Christian Kuhn merged patch set 2 04/20/23, 15:38