78782[BUGFIX] Prevent TypeError in TargetPageIdViewHelper
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Oliver Klee +1
- Christoph Lehmann +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christoph Lehmann +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 1
Review log 89
-
Oli Bartsch uploaded patch set 1 04/21/23, 10:02
-
core-ci voted on patch set 1 V +1 04/21/23, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41025
-
Christoph Lehmann commented on patch set 1 V +1 CR +1 04/21/23, 10:13
An '?int' return value would also be possible for that function. In Overview.html the return value is checked with '<f:if condition="{pageId}>' -
Christoph Lehmann commented on patch set 1 04/21/23, 10:17
Reply
Correction: '?int' is not possible, because pageuid might also be 'current' (string) -
Oliver Klee voted on patch set 1 CR +1 04/21/23, 10:20
-
Jochen Roth voted on patch set 1 V +1 CR +1 04/21/23, 10:33
-
Andreas Kienast voted on patch set 1 V +1 CR +1 04/21/23, 10:41
-
Oli Bartsch voted on patch set 1 V +2 CR +2 04/21/23, 10:45
-
Oli Bartsch merged patch set 2 04/21/23, 10:45