Review main Merged

78786[TASK] Replace the deprecated "braces" php-cs-fixer rule

Christian Kuhn CR +2 V +2 Easy +24 −23 updated 04/21/23, 14:50

Commit message

Current php-cs-fixer notifies:

Rule "braces" is deprecated. Use "single_space_around_construct",
"control_structure_braces", "curly_braces_position",
"control_structure_continuation_position", "declare_parentheses",
"statement_indentation", "no_multiple_statements_per_line"
and "no_extra_blank_lines" instead.

Rule details:

* "single_space_around_construct" - added to config, triggers a couple of changes
* "control_structure_braces" - active via @PER rule set already
* "curly_braces_position" - active via @PER rule set already
* "control_structure_continuation_position" - active via @PER rule set already
* "declare_parentheses" - added to config, no changes
* "statement_indentation" - active via @PER rule set already
* "no_multiple_statements_per_line" - active via @PER rule set already
* "no_extra_blank_lines" - active already

Executed command:

> Build/Scripts/runTests.sh -s cgl

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 13