78791[TASK] Remove PseudoSiteTcaDisplayCondition
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 911
-
Christian Eßl uploaded patch set 1 04/21/23, 18:39
-
core-ci voted on patch set 1 V +1 04/21/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41062
-
Christian Kuhn voted on patch set 1 V +1 CR +1 04/24/23, 12:05
-
Benni Mack commented on patch set 1 CR -1 04/24/23, 12:08
I first want to check if v12-compat extensions still rely on this class / condition. If so, this would be unfortunate for extensions that have been marked as compatible with v12 one day before LTS release. -
Christian Kuhn commented on patch set 1 CR -1 04/24/23, 12:09
benni has some issue with this: There is no hard pressure to merge this one day before v12 lts, it *may* break extensions still using this for whatever reason. maybe we just wait a week and then merge this early in v13. it does not hurt us much at the moment. -
Benni Mack rebased onto patch set 2
CR -1V +107/07/23, 14:33 -
Benni Mack commented on patch set 2 V +1 CR +1 07/07/23, 14:33
fine with me removing it now -
core-ci voted on patch set 2 V +1 07/07/23, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43920
-
Oliver Klee voted on patch set 2 V +1 CR +1 07/07/23, 16:10
-
Georg Ringer voted on patch set 2 V +2 CR +2 07/08/23, 05:36
-
Georg Ringer merged patch set 3 07/08/23, 05:36