Review main Abandoned

78795[DOCS] Fix event listener usage example for ModifyCacheLifetimeForPageEvent

Torben Hansen CR 0 V 0 Easy +1 −0 updated 04/23/23, 16:21

Commit message

The ModifyCacheLifetimeForPageEvent usage example is incomplete since
the event listener registration misses the `event` property.

This patch adds the missing `event` to the event listener registration
example.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Torben Hansen uploaded patch set 1 04/23/23, 11:33

  2. core-ci voted on patch set 1 V +1 04/23/23, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41099

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/23/23, 11:41

  4. core-ci voted on patch set 2 V +1 04/23/23, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41100

  5. Chris Müller commented on patch set 2 04/23/23, 13:29

    Hmm, the event is not necessary since v11?
  6. Torben Hansen commented on patch set 2 04/23/23, 16:20

    Thanks for the

    Reply

    Thanks a lot for pointing this out. I was not aware of that feature. Will abandon this patch and close the issue.
  7. Torben Hansen abandoned the change 04/23/23, 16:21

    Change is not necessary