Review main Merged

78800[TASK] Make IGNORED_EXCEPTION_CODES accessible

Christoph Lehmann CR +2 V +2 Easy +1 −1 updated 04/24/23, 10:59

Commit message

This makes AbstractExceptionHandler::IGNORED_EXCEPTION_CODES public accessible in order to re-use it in custom error handlers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Christoph Lehmann uploaded patch set 1 04/24/23, 08:38

  2. Christoph Lehmann updated the commit message in patch set 2 04/24/23, 08:39

  3. core-ci voted on patch set 2 V +1 04/24/23, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41126

  4. Benni Mack updated the commit message in patch set 3 V +1 04/24/23, 08:48

  5. Oliver Klee voted on patch set 3 CR +1 04/24/23, 08:52

  6. Oliver Klee voted on patch set 3 V +1 04/24/23, 08:52

  7. core-ci voted on patch set 1 V -1 04/24/23, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41125

  8. Christoph Lehmann commented on patch set 3 04/24/23, 09:00

    Thanks! a backport would ease things in v11
  9. core-ci voted on patch set 3 V +1 04/24/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41127

  10. Torben Hansen voted on patch set 3 V +1 CR +1 04/24/23, 09:03

  11. Benni Mack voted on patch set 3 V +2 CR +2 04/24/23, 10:59

  12. Benni Mack merged patch set 4 04/24/23, 10:59