Review main Merged

78814[BUGFIX] Ensure AbstractExceptionHandler::IGNORED_EXCEPTION_CODES is protected

Benni Mack CR +2 V +2 Easy +1 −1 updated 04/24/23, 19:00

Commit message

With #100720 the AbstractExceptionHandlers
const IGNORED_EXCEPTION_CODES was set from private
to public in order to allow to use it in subclasses.

However, public is making this a full public API,
which should be within the ExceptionHandler logic
in general.

For this reason, the constant is now changed from
public to protected.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 04/24/23, 18:37

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 04/24/23, 18:39

  3. core-ci voted on patch set 1 V +1 04/24/23, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41186

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 04/24/23, 18:45

  5. Oliver Klee voted on patch set 1 V +1 CR +1 04/24/23, 18:55

  6. Benni Mack voted on patch set 1 V +2 CR +2 04/24/23, 19:00

  7. Benni Mack merged patch set 2 04/24/23, 19:00