Review main Merged

78832[BUGFIX] Ensure languageId = 0 for new site configurations

Andreas Kienast CR +2 V +2 Easy +9 −2 updated 08/02/23, 13:58

Commit message

When creating a new site configuration, deleting the default language
(English) and importing a new language afterwards now doesn't create an
invalid site configuration with languageId 0 missing.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Andreas Kienast uploaded patch set 1 04/25/23, 05:36

  2. core-ci voted on patch set 1 V +1 04/25/23, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41197

  3. Andreas Kienast updated the commit message in patch set 2 V +1 04/25/23, 05:52

  4. core-ci voted on patch set 2 V +1 04/25/23, 06:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41198

  5. Oli Bartsch commented on patch set 2 V -1 04/25/23, 14:51

    Can confirm the fix for new configurations. However, deleting L=0 is still possible afterwards, which therefore still results in an invalid configuration. Example: - Add new site config - Save - Remove auto generated L=0 language - Add language with "Use language from existing site" - Save => No L=0 is present in the site config
  6. Andreas Kienast commented on patch set 2 04/25/23, 14:53

    Reply Unresolved

    I know, that's why it's fixed for *new* sites only. I have no idea if we can somehow™ prevent the deletion of records with languageId = 0, besides from a custom validation in `validateFullStructure()`.
  7. Benni Mack updated the commit message in patch set 3 V +1 05/03/23, 09:48

  8. Benni Mack rebased onto patch set 4 07/04/23, 13:45

  9. core-ci voted on patch set 4 V +1 07/04/23, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43387

  10. Anja Leichsenring rebased onto patch set 5 V +1 08/02/23, 07:56

  11. Anja Leichsenring voted on patch set 5 V +1 CR +1 08/02/23, 07:56

  12. core-ci voted on patch set 5 V +1 08/02/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44866

  13. Jasmina Ließmann voted on patch set 5 V +1 CR +1 08/02/23, 12:22

  14. Andreas Kienast voted on patch set 5 V +2 CR +2 08/02/23, 13:57

  15. Andreas Kienast merged patch set 6 08/02/23, 13:58