Review main Merged

78873[BUGFIX] Harmonize page ids in Record List search

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 04/27/23, 13:56

Commit message

The list of ids generated by `getSearchableWebmounts()` may contain
duplicated values being passed into an `IN()` criteria, causing
additional load to the database server.

The values are now de-duplicated by applying `array_unique()` onto the
list before passing the list around.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Markus Klein +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Andreas Kienast uploaded patch set 1 04/26/23, 07:05

  2. core-ci voted on patch set 1 V +1 04/26/23, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41238

  3. Oliver Klee voted on patch set 1 CR +1 04/26/23, 08:36

  4. Markus Klein voted on patch set 1 V +1 CR +1 04/26/23, 10:10

  5. Georg Ringer commented on patch set 1 04/26/23, 14:05

    DatabaseRecordList.php:2734

    shouldn't we move the array_unique one line above so that the 1st call gets a smaller list?
  6. Andreas Kienast commented on patch set 1 04/26/23, 14:14

    DatabaseRecordList.php:2734 Reply

    I had that at first, but then `array_unique()` is called multiple times.
  7. Georg Ringer commented on patch set 1 04/26/23, 16:09

    DatabaseRecordList.php:2734 Reply

    more like this $idList = array_unique($idList); $runtimeCache->set($hash, $idList);
  8. Andreas Kienast commented on patch set 1 04/26/23, 16:40

    DatabaseRecordList.php:2734 Reply

    I don‘t see the benefit, but I honestly don‘t care.
  9. Frank Nägler voted on patch set 1 V +1 CR +1 04/27/23, 13:56

  10. Andreas Kienast voted on patch set 1 V +2 CR +2 04/27/23, 13:56

  11. Andreas Kienast merged patch set 2 04/27/23, 13:56