Review main Merged

78875[DOCS] Update SECURITY.md

Stephan Großberndt CR +2 V +2 Normal +41 −28 updated 04/29/23, 19:42

Commit message

Further improvements, most of them as proposed by Michael Schams

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Thomas Hohn +1
    • Torben Hansen +1
    • Anja Leichsenring +1
    • Michael Schams +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Thomas Hohn +1
    • Torben Hansen +1
    • Anja Leichsenring +1
    • Michael Schams +1
    • Jörg Bösche +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1519

  1. Stephan Großberndt uploaded patch set 1 04/26/23, 08:01

  2. core-ci voted on patch set 1 V +1 04/26/23, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41241

  3. Stephan Großberndt uploaded patch set 2 V +1 04/26/23, 08:30

  4. core-ci voted on patch set 2 V +1 04/26/23, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41242

  5. Stephan Großberndt updated the commit message in patch set 3 V +1 04/26/23, 09:02

  6. core-ci voted on patch set 3 V +1 04/26/23, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41244

  7. Stephan Großberndt commented on patch set 3 04/26/23, 09:13

    I asked Michael Schams to check and improve the file, I added his proposals here - thanks Michael! I also did some more cleanup and improvements on top of that. Regarding the direct use of emojis vs rendered by gitlab/github I am undecided, just noticed it is nicer to have the emojis on the console as well..
  8. Georg Ringer voted on patch set 3 V +1 CR +1 04/26/23, 13:27

  9. Michael Schams commented on patch set 3 04/27/23, 02:27

    Good idea to move the encryption part into the section "Reporting a Vulnerability".

    Reply

    Although I truly like the usage of emojis in general, I suggest NOT to use them in a text or markdown file such as SECURITY.MD. Files like this are too important and some user interfaces (editors, console, etc.) don't show Unicode characters or emojis properly. I uploaded an example to the forge ticket. The focus on these files should be the information that the files contain, not a nice look necessarily.
  10. Stephan Großberndt uploaded patch set 4 CR +1 V +1 04/27/23, 14:49

  11. Stephan Großberndt commented on patch set 4 04/27/23, 14:50

    Reply

    Ack

    Reply

    Ack
  12. core-ci voted on patch set 4 V +1 04/27/23, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41272

  13. Michael Schams voted on patch set 4 V +1 CR +1 04/27/23, 22:57

  14. Anja Leichsenring voted on patch set 4 V +1 CR +1 04/28/23, 08:39

  15. Jörg Bösche voted on patch set 4 V +1 CR +1 04/28/23, 09:07

  16. Thomas Hohn voted on patch set 4 V +1 CR +1 04/28/23, 11:18

  17. Torben Hansen voted on patch set 4 V +1 CR +1 04/29/23, 10:20

  18. Benni Mack voted on patch set 4 V +2 CR +2 04/29/23, 19:42

  19. Benni Mack merged patch set 5 04/29/23, 19:42