Review main Merged

78876[BUGFIX] Fix visual glitches in tile view affecting Firefox

Andreas Kienast CR +2 V +2 Easy +2 −1 updated 04/26/23, 13:40

Commit message

`text-overflow: ellipsis` only works in Firefox if the parent element
has an explicit width. Therefore, `button` and `a` elements are now set
to a width of 100%. This also fixes an issue where images appear to be
squeezed in Firefox.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Daniel Siepmann +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Andreas Kienast uploaded patch set 1 04/26/23, 08:54

  2. Benni Mack commented on patch set 1 04/26/23, 08:56

    we had this problem at our release party yesterday
  3. Benni Mack voted on patch set 1 CR +1 04/26/23, 08:56

  4. Markus Klein voted on patch set 1 V +1 CR +1 04/26/23, 08:59

  5. core-ci voted on patch set 1 V +1 04/26/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41243

  6. Andreas Kienast updated the commit message in patch set 2 CR +1 V +1 04/26/23, 12:26

  7. Markus Klein voted on patch set 2 V +1 CR +1 04/26/23, 12:29

  8. core-ci voted on patch set 2 V +1 04/26/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41250

  9. Daniel Siepmann commented on patch set 2 V +1 04/26/23, 12:33

    The full title is still available via title attribute. So still available to the user while hovering. Thanks for the fast fix.
  10. Benjamin Kott voted on patch set 2 V +1 CR +1 04/26/23, 13:35

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 04/26/23, 13:40

  12. Andreas Kienast merged patch set 3 04/26/23, 13:40