Review main Merged

78880[BUGFIX] Allow import module to also access distributions

Benjamin Kott CR +2 V +2 Normal +43 −14 updated 07/07/23, 13:38

Commit message

This patch streamlines the import module with the import command.
While the CLI commands can import data from extensions, the interface
has no option to perform this action. We are now listing available
datasets from distributions in the import module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2129

Show 34 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/26/23, 14:21

  2. core-ci voted on patch set 1 V +1 04/26/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41254

  3. Benjamin Kott uploaded patch set 2 V +1 04/26/23, 14:58

  4. Oliver Klee commented on patch set 2 04/26/23, 15:41

    Issue number missing - still WIP?
  1. core-ci voted on patch set 2 V -1 04/26/23, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41255

  2. Benjamin Kott commented on patch set 2 04/26/23, 19:33

    y added a quick poc to show benni
  3. Benjamin Kott updated the commit message in patch set 3 V -1 04/26/23, 19:33

  4. core-ci voted on patch set 3 V -1 04/26/23, 20:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41256

  5. Benni Mack updated the commit message in patch set 4 V -1 05/03/23, 09:49

  6. Benjamin Kott uploaded patch set 5 07/05/23, 21:19

  7. Benni Mack commented on patch set 5 07/05/23, 21:19

    Reply

    Done
  8. core-ci voted on patch set 5 V -1 07/05/23, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43642

  9. Benjamin Kott uploaded patch set 6 V -1 07/06/23, 08:14

  10. core-ci voted on patch set 6 V +1 07/06/23, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43666

  11. Benni Mack voted on patch set 6 CR -1 07/06/23, 11:36

  12. Benni Mack voted on patch set 6 V +1 CR +1 07/06/23, 18:20

  13. Benni Mack commented on patch set 6 V 0 CR -1 07/06/23, 18:20

    Can we do this only for admins? And should this go only in pid=0 then?
  14. Benni Mack voted on patch set 6 CR 0 07/06/23, 19:14

  15. Benjamin Kott uploaded patch set 7 V +1 07/06/23, 20:32

  16. core-ci voted on patch set 7 V -1 07/06/23, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43833

  17. Benjamin Kott rebased onto patch set 8 V -1 07/07/23, 06:57

  18. core-ci voted on patch set 8 V +1 07/07/23, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43853

  19. Susi Moog commented on patch set 8 CR -1 07/07/23, 09:58

    ImportExport.php:607

    do $databaseRecord === null instead.
  20. Benjamin Kott uploaded patch set 9 CR -1 V +1 07/07/23, 11:50

  21. core-ci voted on patch set 9 V +1 07/07/23, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43898

  22. Benjamin Kott commented on patch set 9 07/07/23, 12:28

    ImportExport.php:607 Reply

    Done
  23. Susi Moog voted on patch set 9 V +1 CR +1 07/07/23, 12:35

  24. Benni Mack voted on patch set 9 V +2 CR +2 07/07/23, 13:38

  25. Benni Mack merged patch set 10 07/07/23, 13:38