78880[BUGFIX] Allow import module to also access distributions
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/impexp/Classes/Controller/ImportController.php+27 −1
- typo3/sysext/impexp/Classes/ImportExport.php2+4 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.php+5 −5
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.php+7 −7
Review log 2129
Show 34 earlier messages
-
Benjamin Kott uploaded patch set 1 04/26/23, 14:21
-
core-ci voted on patch set 1 V +1 04/26/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41254
-
Benjamin Kott uploaded patch set 2
V +104/26/23, 14:58 -
Oliver Klee commented on patch set 2 04/26/23, 15:41
Issue number missing - still WIP?
-
core-ci voted on patch set 2 V -1 04/26/23, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41255
-
Benjamin Kott commented on patch set 2 04/26/23, 19:33
y added a quick poc to show benni -
Benjamin Kott updated the commit message in patch set 3
V -104/26/23, 19:33 -
core-ci voted on patch set 3 V -1 04/26/23, 20:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41256
-
Benni Mack updated the commit message in patch set 4
V -105/03/23, 09:49 -
Benjamin Kott uploaded patch set 5 07/05/23, 21:19
-
Benni Mack commented on patch set 5 07/05/23, 21:19
Reply
Done -
core-ci voted on patch set 5 V -1 07/05/23, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43642
-
Benjamin Kott uploaded patch set 6
V -107/06/23, 08:14 -
core-ci voted on patch set 6 V +1 07/06/23, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43666
-
Benni Mack voted on patch set 6 CR -1 07/06/23, 11:36
-
Benni Mack voted on patch set 6 V +1 CR +1 07/06/23, 18:20
-
Benni Mack commented on patch set 6 V 0 CR -1 07/06/23, 18:20
Can we do this only for admins? And should this go only in pid=0 then? -
Benni Mack voted on patch set 6 CR 0 07/06/23, 19:14
-
Benjamin Kott uploaded patch set 7
V +107/06/23, 20:32 -
core-ci voted on patch set 7 V -1 07/06/23, 20:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43833
-
Benjamin Kott rebased onto patch set 8
V -107/07/23, 06:57 -
core-ci voted on patch set 8 V +1 07/07/23, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43853
-
Susi Moog commented on patch set 8 CR -1 07/07/23, 09:58
ImportExport.php:607do $databaseRecord === null instead. -
Benjamin Kott uploaded patch set 9
CR -1V +107/07/23, 11:50 -
core-ci voted on patch set 9 V +1 07/07/23, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43898
-
Benjamin Kott commented on patch set 9 07/07/23, 12:28
ImportExport.php:607ReplyDone -
Susi Moog voted on patch set 9 V +1 CR +1 07/07/23, 12:35
-
Benni Mack voted on patch set 9 V +2 CR +2 07/07/23, 13:38
-
Benni Mack merged patch set 10 07/07/23, 13:38