Review main Merged

78881[BUGFIX] Use `importShim()` to load init modules

Andreas Kienast CR +2 V +2 Easy +10 −10 updated 04/28/23, 16:31

Commit message

With #100688, the module `es-module-shims` was updated. Unfortunately,
with 1.5.3 an incompatibility with Firefox < 108 was introduced,
affecting current Firefox ESR releases (currently at 102, at the time
of writing this patch).

To workaround this issue, the init scripts used in the Install Tool now
use `importShim()` for the time being, until Firefox ESR hits version
108.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 67

  1. Andreas Kienast uploaded patch set 1 04/27/23, 11:13

  2. core-ci voted on patch set 1 V +1 04/27/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41269

  3. Markus Klein voted on patch set 1 CR +1 04/27/23, 11:58

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 04/28/23, 08:40

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 04/28/23, 12:29

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 04/28/23, 16:31

  7. Andreas Kienast merged patch set 2 04/28/23, 16:31