78885[WIP] Build CSS
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 14
- Build/gitlab-ci/nightly/integrity.yml+2 −3
- Build/gitlab-ci/pre-merge/integrity.yml+3 −4
- Build/Scripts/runTests.sh+4 −11
- Build/testing-docker/local/docker-compose.yml+5 −23
- Build/build-css.mjsnew+175 −0
- Build/Gruntfile.js+5 −173
- Build/package-lock.json+653 −398
- Build/package.json+5 −8
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+6 −6
- typo3/sysext/backend/Resources/Public/Css/backend.css+46 −46
- typo3/sysext/backend/Resources/Public/Css/webfonts.css+16 −16
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+1 −1
- typo3/sysext/form/Resources/Public/Css/form.css+2 −2
- .editorconfig+2 −2
Review log 1727
Show 12 earlier messages
-
Benjamin Kott uploaded patch set 1 04/27/23, 16:42
-
core-ci voted on patch set 1 V +1 04/27/23, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41276
-
Benjamin Kott uploaded patch set 2
V +104/28/23, 07:12 -
core-ci voted on patch set 2 V -1 04/28/23, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41288
-
Benjamin Kott uploaded patch set 3
V -104/28/23, 11:05 -
Benjamin Kott uploaded patch set 4 04/28/23, 11:31
-
core-ci voted on patch set 3 V -1 04/28/23, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41289
-
Benjamin Kott uploaded patch set 5 04/28/23, 11:43
-
core-ci voted on patch set 4 V -1 04/28/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41290
-
core-ci voted on patch set 5 V -1 04/28/23, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41294
-
Benjamin Kott uploaded patch set 6
V -104/28/23, 12:33 -
core-ci voted on patch set 6 V -1 04/28/23, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41296
-
Benjamin Kott uploaded patch set 7
V -105/02/23, 07:34 -
core-ci voted on patch set 7 V +1 05/02/23, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41336
-
Benjamin Kott uploaded patch set 8
V +105/02/23, 07:54 -
core-ci voted on patch set 8 V +1 05/02/23, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41338
-
Oliver Hader commented on patch set 8 V +1 05/02/23, 08:23
Works on macOS Ventura 13.3 (Intel) -
Oliver Hader commented on patch set 8 05/02/23, 08:29
Tested `Build/Scripts/runTests.sh -s buildCss` & `Build/Scripts/runTests.sh -s buildJavascript` via Docker Desktop 4.19.0 on macOS (Intel) as well. -
Benjamin Kott commented on patch set 8 05/02/23, 08:39
Reply
can you also run `npm run build-css` outside of docker? -
Oliver Hader commented on patch set 8 05/02/23, 08:57
Reply
I ran `npm run build` earlier, which looked good. * before this patch `time npm run build-css 12.54s user 0.61s system 144% cpu 9.069 total` * after this patch `time npm run build-css 5.97s user 0.77s system 155% cpu 4.324 total` → this patch reduced CSS build time to just ~48% -
Christian Kuhn uploaded patch set 9
V +105/02/23, 18:42 -
Christian Kuhn commented on patch set 9 05/02/23, 18:44
we updated the js images to deal with this change and rebased the patch accordingly. -
core-ci voted on patch set 9 V +1 05/02/23, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41362
-
Benjamin Kott uploaded patch set 10
V +105/04/23, 14:32 -
core-ci voted on patch set 10 V +1 05/04/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41573
-
Christian Kuhn commented on patch set 10 08/06/24, 14:48
hey. abandoned for now. please resurrect if this is picked up and leads to something. -
Christian Kuhn abandoned the change 08/06/24, 14:48