Review main Abandoned

78885[WIP] Build CSS

Benjamin Kott CR 0 V 0 Expert +925 −693 updated 08/06/24, 14:48

Commit message

- Introduced custom build script for css handling
- Removed obsolete grunt dependencies
- Replaced sass with sass-embedded
- Switched ci base images to node:16-slim

Review

  • Code review CR 0
  • Verified V 0

Files 14

Review log 1727

Show 12 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/27/23, 16:42

  2. core-ci voted on patch set 1 V +1 04/27/23, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41276

  1. Benjamin Kott uploaded patch set 2 V +1 04/28/23, 07:12

  2. core-ci voted on patch set 2 V -1 04/28/23, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41288

  3. Benjamin Kott uploaded patch set 3 V -1 04/28/23, 11:05

  4. Benjamin Kott uploaded patch set 4 04/28/23, 11:31

  5. core-ci voted on patch set 3 V -1 04/28/23, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41289

  6. Benjamin Kott uploaded patch set 5 04/28/23, 11:43

  7. core-ci voted on patch set 4 V -1 04/28/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41290

  8. core-ci voted on patch set 5 V -1 04/28/23, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41294

  9. Benjamin Kott uploaded patch set 6 V -1 04/28/23, 12:33

  10. core-ci voted on patch set 6 V -1 04/28/23, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41296

  11. Benjamin Kott uploaded patch set 7 V -1 05/02/23, 07:34

  12. core-ci voted on patch set 7 V +1 05/02/23, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41336

  13. Benjamin Kott uploaded patch set 8 V +1 05/02/23, 07:54

  14. core-ci voted on patch set 8 V +1 05/02/23, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41338

  15. Oliver Hader commented on patch set 8 V +1 05/02/23, 08:23

    Works on macOS Ventura 13.3 (Intel)
  16. Oliver Hader commented on patch set 8 05/02/23, 08:29

    Tested `Build/Scripts/runTests.sh -s buildCss` & `Build/Scripts/runTests.sh -s buildJavascript` via Docker Desktop 4.19.0 on macOS (Intel) as well.
  17. Benjamin Kott commented on patch set 8 05/02/23, 08:39

    Reply

    can you also run `npm run build-css` outside of docker?
  18. Oliver Hader commented on patch set 8 05/02/23, 08:57

    Reply

    I ran `npm run build` earlier, which looked good. * before this patch `time npm run build-css 12.54s user 0.61s system 144% cpu 9.069 total` * after this patch `time npm run build-css 5.97s user 0.77s system 155% cpu 4.324 total` → this patch reduced CSS build time to just ~48%
  19. Christian Kuhn uploaded patch set 9 V +1 05/02/23, 18:42

  20. Christian Kuhn commented on patch set 9 05/02/23, 18:44

    we updated the js images to deal with this change and rebased the patch accordingly.
  21. core-ci voted on patch set 9 V +1 05/02/23, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41362

  22. Benjamin Kott uploaded patch set 10 V +1 05/04/23, 14:32

  23. core-ci voted on patch set 10 V +1 05/04/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41573

  24. Christian Kuhn commented on patch set 10 08/06/24, 14:48

    hey. abandoned for now. please resurrect if this is picked up and leads to something.
  25. Christian Kuhn abandoned the change 08/06/24, 14:48