Review 12.4 Merged

78898[BUGFIX] Change selector to get container in `files` element

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 05/05/23, 09:32

Commit message

The identifier used to get a container in `type=files` based on
`querySelector()` which flawed if the identifier contained a dot.
The example identifier "#foo-data-foo.bar" resulted in "find an
element with id 'foo-data-foo', having the class 'bar'", which
is wrong.

To solve this issue, while still limiting the scope to the web
component, the selector is changed to use the `[id='']` syntax,
which doesn't show the erroneous behavior.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2