Review main Merged

78912[TASK] Remove superfluous timestamp CKEditor plugin

Torben Hansen CR +2 V +2 Easy +5 −21 updated 05/02/23, 10:44

Commit message

With #96874, the timestamp example plugin for CKEditor has been
added to `ext:rte_ckeditor`. The plugin is however not used or
referenced anywhere, so it can safely be removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Torben Hansen uploaded patch set 1 04/30/23, 16:55

  2. Thomas Hohn voted on patch set 1 CR +1 05/01/23, 04:39

  3. Stefan Bürk updated the commit message in patch set 2 CR +1 05/01/23, 07:13

  4. core-ci voted on patch set 2 V +1 05/01/23, 07:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41320

  5. Oliver Hader uploaded patch set 3 V +1 05/02/23, 09:08

  6. Oliver Hader commented on patch set 3 V +1 CR +1 05/02/23, 09:10

    Good catch! This file accidentally slipped into the final commit. It was used as demo for the documentation at https://docs.typo3.org/c/typo3/cms-core/main/en-us//Changelog/12.0/Breaking-96874-CKEditor-relatedPluginsAndConfiguration.html The source in the docs was copy-pasted from the original source - and still contained the `@todo` to remove this JavaScript module later... 😄
  7. core-ci voted on patch set 3 V +1 05/02/23, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41339

  8. Benni Mack voted on patch set 3 V +2 CR +2 05/02/23, 10:44

  9. Benni Mack merged patch set 4 05/02/23, 10:44