78923[BUGFIX] Create session cookie when explicitly requested
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Thomas Hohn +1
- Markus Klein +1
- Daniel Haupt +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Haupt +1
- core-ci +1 CI
Issues 1
Files 1
Review log 67
-
Oliver Hader uploaded patch set 1 05/02/23, 18:43
-
Markus Klein voted on patch set 1 CR +1 05/02/23, 18:50
-
core-ci voted on patch set 1 V +1 05/02/23, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41363
-
Thomas Hohn voted on patch set 1 CR +1 05/02/23, 19:01
-
Daniel Haupt commented on patch set 1 V +1 CR +1 05/03/23, 07:04
The issue could also be fixed by simply adding `$this->dontSetCookie = false;` before calling `setSessionCookie()` in `\TYPO3\CMS\Frontend\Authentication\FrontendUserAuthentication:440`. But I guess the change is fine, since the method `setSessionCookie` is public API. However, I can confirm the fix is working when using `$GLOBALS['TSFE']->fe_user->setKey()`. -
Benni Mack voted on patch set 1 V +2 CR +2 05/03/23, 07:54
-
Oliver Hader merged patch set 2 05/03/23, 08:03