Review main Merged

78929[BUGFIX] Don't try to render icon for empty identifier

Oli Bartsch CR +2 V +2 Easy +5 −1 updated 05/05/23, 09:19

Commit message

In case a site is missing a proper site
configuration - having no default language
a fallback SiteLanguage object is used in
the page module. This fallback however does
provide an empty string as flag identifier,
which does no longer result in a broken icon.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Daniel Haupt +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Jochen Roth +1
    • Daniel Haupt +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 05/03/23, 15:38

  2. core-ci voted on patch set 1 V +1 05/03/23, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41538

  3. Oliver Klee voted on patch set 1 CR +1 05/03/23, 15:58

  4. Daniel Haupt commented on patch set 1 V +1 CR +1 05/04/23, 20:58

    Should we make the commit subject a bit more precise? Proposal: [BUGFIX] Prevent rendering flag icon without site
  5. Jochen Roth voted on patch set 1 V +1 CR +1 05/05/23, 07:40

  6. Andreas Kienast voted on patch set 1 V +1 CR +1 05/05/23, 08:35

  7. Nikita Hovratov voted on patch set 1 V +2 CR +2 05/05/23, 09:19

  8. Nikita Hovratov merged patch set 2 05/05/23, 09:19