Review main Merged

78939[TASK] Require typo3fluid/fluid:^2.8.0

Christian Kuhn CR +2 V +2 Easy +17 −17 updated 05/05/23, 07:22

Commit message

Minor release update from ^2.7.4 to ^2.8.0:

- main/v13: Require ^2.8.0
- v12: Require ^2.8.0, projects will update
  with next core patch level release
- v11: No change, projects *may* be able to
  update if running PHP ^8.1 and having
  mbstring
- v10: No change, projects won't be able to
  update since core does not allow PHP 8.1

Notable changes:

- Require PHP ^8.1 and mbstring

- Syntax improvement: A comma with spaces and
  line breaks on last fluid "arrays" and inline
  syntax is now parsed as expected.

  <f:variable
    name="myArray" value="{
      0: 'first item',
      1: 'second item',
    }"
  />

  {f:if(
    condition: myVariable,
    then: 'yes',
    else: 'no',
  )}

- Syntax improvement: Resolve multi variable references
  correctly.

  {foo}bar{baz}
  foo.{bar}.{baz}

- PHP 8.1 fix when resolving invalid variable references

  {{notExistingVariable}}

- General performance improvements when resolving variables. This
  boosts templates that access lots of variables which resolve
  to object methods like {object.name} to $object->getName().
  This has measurable impact for instance in the backend "log"
  module when rendering many rows, and reduces overall parsetime
  by about 1/4 in the TypoScript "Active TypoScript" module when
  rendering bigger TypoScript trees like the bootstrap package.

Commands:

> composer req typo3fluid/fluid:^2.8.0
> composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/adminpanel
> composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/core
> composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/fluid
> composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/redirects

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 610

  1. Christian Kuhn uploaded patch set 1 05/04/23, 22:31

  2. Christian Kuhn uploaded patch set 2 05/04/23, 22:35

  3. core-ci voted on patch set 1 V -1 05/04/23, 22:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41580

  4. core-ci voted on patch set 2 V +1 05/04/23, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41581

  5. Christian Kuhn updated the commit message in patch set 3 V +1 05/04/23, 23:02

  6. core-ci voted on patch set 3 V +1 05/04/23, 23:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41584

  7. core-ci voted on patch set 2 V +1 05/04/23, 23:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41583

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/05/23, 04:17

  9. Stefan Bürk voted on patch set 3 V +2 CR +2 05/05/23, 07:21

  10. Stefan Bürk merged patch set 4 05/05/23, 07:22