Review 12.4 Merged

78940[TASK] Require typo3fluid/fluid:^2.8.0

Christian Kuhn CR +2 V +2 Easy +17 −17 updated 05/05/23, 07:22

Commit message

Minor release update from ^2.7.4 to ^2.8.0:

- main/v13: Require ^2.8.0
- v12: Require ^2.8.0, projects will update
  with next core patch level release
- v11: No change, projects *may* be able to
  update if running PHP ^8.1 and having
  mbstring
- v10: No change, projects won't be able to
  update since core does not allow PHP 8.1

Notable changes:

- Require PHP ^8.1 and mbstring

- Syntax improvement: A comma with spaces and
  line breaks on last fluid "arrays" and inline
  syntax is now parsed as expected.

  <f:variable
    name="myArray" value="{
      0: 'first item',
      1: 'second item',
    }"
  />

  {f:if(
    condition: myVariable,
    then: 'yes',
    else: 'no',
  )}

- Syntax improvement: Resolve multi variable references
  correctly.

  {foo}bar{baz}
  foo.{bar}.{baz}

- PHP 8.1 fix when resolving invalid variable references

  {{notExistingVariable}}

- General performance improvements when resolving variables. This
  boosts templates that access lots of variables which resolve
  to object methods like {object.name} to $object->getName().
  This has measurable impact for instance in the backend "log"
  module when rendering many rows, and reduces overall parsetime
  by about 1/4 in the TypoScript "Active TypoScript" module when
  rendering bigger TypoScript trees like the bootstrap package.

Commands:

> composer req typo3fluid/fluid:^2.8.0
> composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/adminpanel
> composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/core
> composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/fluid
> composer req --no-update typo3fluid/fluid:^2.8.0 -d typo3/sysext/redirects

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 47

  1. Christian Kuhn uploaded patch set 1 05/04/23, 22:37

  2. core-ci voted on patch set 1 V +1 05/04/23, 23:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41582

  3. Christian Kuhn updated the commit message in patch set 2 V +1 05/04/23, 23:03

  4. core-ci voted on patch set 2 V +1 05/04/23, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41585

  5. core-ci commented on patch set 2 05/04/23, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41586

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 05/05/23, 07:22

  7. Stefan Bürk merged patch set 3 05/05/23, 07:22