Review main Merged

78946[TASK] Consistently limit scope in FilesControlContainer

Oli Bartsch CR +2 V +2 Normal +85 −91 updated 05/08/23, 13:06

Commit message

Since we are in the scope of a web component,
access to "document" is now consistently avoided.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Oli Bartsch uploaded patch set 1 05/05/23, 10:03

  2. core-ci voted on patch set 1 V +1 05/05/23, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41606

  3. Nikita Hovratov commented on patch set 1 05/05/23, 19:43

    files-control-container.ts:87

    unrelated, but can we fix this typo?
  4. Oliver Klee commented on patch set 1 05/05/23, 20:20

    files-control-container.ts:87 Reply

  5. Oli Bartsch uploaded patch set 2 V +1 05/07/23, 07:44

  6. core-ci voted on patch set 2 V +1 05/07/23, 07:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41640

  7. Oli Bartsch uploaded patch set 3 V +1 05/08/23, 06:16

  8. core-ci voted on patch set 3 V +1 05/08/23, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41650

  9. Nikita Hovratov voted on patch set 3 V +1 CR +1 05/08/23, 09:05

  10. Jochen Roth voted on patch set 3 V +1 CR +1 05/08/23, 13:04

  11. Oli Bartsch voted on patch set 3 V +2 CR +2 05/08/23, 13:06

  12. Oli Bartsch merged patch set 4 05/08/23, 13:06