78956[TASK] Add StringUtility::cast and ::filter
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Markus Klein +1
-
Verified V +2 Done
- Oliver Hader +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1722
-
Oliver Klee uploaded patch set 1 05/07/23, 11:28
-
core-ci voted on patch set 1 V +1 05/07/23, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41641
-
Oliver Klee uploaded patch set 2
V +105/07/23, 13:25 -
core-ci voted on patch set 2 V +1 05/07/23, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41642
-
Markus Klein commented on patch set 2 05/07/23, 21:19
This needs an rst file -
Georg Ringer commented on patch set 2 05/08/23, 06:54
either it is a feature, than it needs a rst + only for main branch or we switch that to a task and it would be fine. maybe benni or olly can decide? I am also not yet sure if features are already allowed for main -
Oliver Hader updated the commit message in patch set 3
V +105/08/23, 06:58 -
Oliver Hader commented on patch set 3 05/08/23, 06:59
I changed it to be a `[TASK]` now. -
core-ci voted on patch set 3 V +1 05/08/23, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41652
-
Oliver Hader commented on patch set 4
V +105/08/23, 07:14Published edit on patch set 3. -
Oliver Hader commented on patch set 4 05/08/23, 07:15
I changed 3 test methods to be non-static, since they are invoked on an actual instance of the test class. -
Oliver Hader voted on patch set 4 V +1 CR +1 05/08/23, 07:15
-
Georg Ringer voted on patch set 4 V +1 CR +1 05/08/23, 07:19
-
core-ci voted on patch set 4 V +1 05/08/23, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41653
-
Oliver Klee commented on patch set 4 05/08/23, 07:52
@Olly: As your fix https://review.typo3.org/c/Packages/TYPO3.CMS/+/78816 also is for 11.5, would it be okay to target this change here for 11.5 as well? (When it was still a feature, I assumed having a new feature in 11.5 would not be okay, but now it being a task things might be different.) -
Oliver Klee commented on patch set 4 05/08/23, 07:53
Reply
Resolved by switching this to a TASK. -
Oliver Klee updated the commit message in patch set 5
CR +1V +105/08/23, 19:17 -
Markus Klein voted on patch set 5 CR +1 05/08/23, 19:24
-
core-ci voted on patch set 5 V +1 05/08/23, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41673
-
Georg Ringer voted on patch set 5 V +1 CR +1 05/09/23, 04:44
-
Oliver Hader voted on patch set 5 V +2 CR +2 05/09/23, 07:13
-
Oliver Hader merged patch set 6 05/09/23, 07:14