Review main Merged

78959[BUGFIX] Preserve native CKEditor5 related toolbar settings

Stefan Froemken CR +2 V +2 Normal +92 −2 updated 09/15/23, 10:45

Commit message

If the CKEditor is configured with the new v5-style
`toolbar.removeItems` option instead of `removeButtons` (v4), the
CKEditor5Migrator will now merge`removeItems` with `removeButtons`.

Also do not overwrite `toolbar.shouldNotGroupWhenFull`, allowing
it to be set to false.

Note that v5-style `toolbar.items` where already defined to
be used when v4-style `toolbarGroups` are empty, so we do
not change this behavior.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2