Review main Merged

78960[BUGFIX] Prevent PHP Warning in CKEditor5Migrator

Stefan Froemken CR +2 V +2 Normal +53 −2 updated 06/08/23, 15:11

Commit message

In CKEditor 4 the option "removeButtons"
can also be a comma separated list of strings.
CKEditor5Migrator now respects the old
string value and converts it to an array
before migrating the value.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Stefan Froemken uploaded patch set 1 05/08/23, 10:44

  2. core-ci voted on patch set 1 V +1 05/08/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41659

  3. Oliver Klee voted on patch set 1 CR +1 05/08/23, 11:15

  4. Andreas Kienast commented on patch set 1 CR -1 05/09/23, 06:31

    Can you please provide a test for this case?
  5. Stefan Froemken uploaded patch set 2 CR +1 V +1 05/09/23, 12:55

  6. Stefan Froemken commented on patch set 2 05/09/23, 12:56

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 05/09/23, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41703

  8. Oliver Klee voted on patch set 2 V +1 CR +1 05/09/23, 13:14

  9. Stefan Bürk commented on patch set 2 05/11/23, 17:52

    CKEditor5Migrator.php:455

    Shouldn't we use `true` as third argument for `trimExplode()` ? to remove empty values directly from the resulting array ?
  10. Stefan Froemken uploaded patch set 3 CR +1 V +1 05/22/23, 07:38

  11. Stefan Froemken commented on patch set 2 05/22/23, 07:44

    CKEditor5Migrator.php:455 Reply

    Done
  12. core-ci voted on patch set 3 V +1 05/22/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41955

  13. Oliver Klee voted on patch set 3 V +1 CR +1 05/22/23, 08:02

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 06/08/23, 15:11

  15. Christian Kuhn merged patch set 4 06/08/23, 15:11