Review main Merged

79005[TASK] Raise 'phpstan/phpstan' and regenerate baseline

Anja Leichsenring CR +2 V +2 Easy +12 −7 updated 05/11/23, 06:01

Commit message

A new patch level requires to regenerate baseline.

> composer req --dev phpstan/phpstan:^1.10.15
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Thomas Hohn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Anja Leichsenring uploaded patch set 1 05/10/23, 05:18

  2. core-ci voted on patch set 1 V -1 05/10/23, 05:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41716

  3. Anja Leichsenring uploaded patch set 2 V -1 05/10/23, 05:40

  4. Thomas Hohn voted on patch set 2 CR +1 05/10/23, 05:41

  5. core-ci voted on patch set 2 V +1 05/10/23, 05:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41717

  6. Oliver Klee commented on patch set 2 05/10/23, 07:40

    For PHPStan raises (combined with baseline updates), we usually also raise the minimum PHPStan version (so people won't get different baselines) and add the 11.5 backport to keep the baselines in sync: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78611
  7. Anja Leichsenring uploaded patch set 3 CR +1 V +1 05/11/23, 05:28

  8. Anja Leichsenring commented on patch set 3 05/11/23, 05:29

    Reply

    thanks for the reference, I updated the patch accordingly now.
  9. core-ci voted on patch set 3 V +1 05/11/23, 05:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41747

  10. Stefan Bürk voted on patch set 3 V +1 CR +1 05/11/23, 05:44

  11. Thomas Hohn voted on patch set 3 CR +1 05/11/23, 05:52

  12. Stefan Bürk commented on patch set 3 V +2 CR +2 05/11/23, 06:01

    merging, also one missing verified. only dev/testing related and recurring default procedure.
  13. Stefan Bürk merged patch set 4 05/11/23, 06:01