79019[BUGFIX] Use proper path to get size of used files in admin panel
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Elias Häußler +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Froemken +1
- Elias Häußler +1
- core-ci +1 CI
Issues 1
Files 1
Review log 910
-
Georg Ringer uploaded patch set 1 05/12/23, 09:00
-
Georg Ringer commented on patch set 1 05/12/23, 09:00
This change is ready for review. -
core-ci voted on patch set 1 V +1 05/12/23, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41772
-
Stefan Froemken commented on patch set 1 V +1 05/22/23, 08:18
Patch works. As I don't know that section until know, it needs some time to find that. So I would prefer updating the description a little bit. Something like: If images are embedded on the website, the image size is now calculated correctly in the Info module of the AdminPanel in the tab "General". -
Benni Mack commented on patch set 1 05/23/23, 09:26
GeneralInformation.php:125how about using GeneralUtility::getFileAbsFileName() ? -
Georg Ringer commented on patch set 1 05/23/23, 17:36
GeneralInformation.php:125Replydoes not work, "/fileadmin/_processed_/d/5/csm_Bildschirmfoto_2022-02-14_um_08.34.45_38948c7c33.png" returns empty string -
Benni Mack commented on patch set 1 05/23/23, 20:14
GeneralInformation.php:125ReplyAck -
Elias Häußler voted on patch set 1 V +1 CR +1 06/08/23, 13:54
-
Christian Kuhn voted on patch set 1 V +2 CR +2 06/08/23, 14:04
-
Christian Kuhn merged patch set 2 06/08/23, 14:04