Review main Merged

79023[BUGFIX] Remove language section from base CKEditor config

Andreas Nedbal CR +2 V +2 Easy +0 −5 updated 06/06/23, 15:08

Commit message

If the language section is configured it prevents the backend
from applying the current backend user locale to the CKEditor
UI.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Nedbal uploaded patch set 1 05/12/23, 22:49

  2. core-ci voted on patch set 1 V +1 05/12/23, 22:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41786

  3. Andreas Nedbal updated the commit message in patch set 2 V +1 05/13/23, 01:03

  4. core-ci voted on patch set 2 V +1 05/13/23, 01:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41789

  5. Torben Hansen commented on patch set 2 05/13/23, 17:05

    I tested the patch and it seems to fix the problem, that the language for content/UI is not applied. When I switch to german language, the editor however still remains in englisch language. To me it seems, that we do not have any language packs for CKEditor 5 at all in v12/main
  6. Andreas Nedbal commented on patch set 2 05/13/23, 20:45

    Reply

    I'd like to keep the scope of this patch down and fix the issue with the never applying languages here only. I think for the language packs we need some additional logic that (similar to what we already do with the Inspector) only loads the requested languages, so we keep the bundle size low and the backend fast.
  7. Torben Hansen commented on patch set 2 V +1 CR +1 05/15/23, 07:30

    Reply

    Ack
  8. Benni Mack voted on patch set 2 V +2 CR +2 06/06/23, 15:08

  9. Benni Mack merged patch set 3 06/06/23, 15:08