Review main Merged

79025[BUGFIX] Properly align positioning line at the end of tree

Andreas Nedbal CR +2 V +2 Easy +8 −2 updated 06/08/23, 11:00

Commit message

The positioning line is always shown above elements, regardless
of dragging position. This is most likely done to prevent jitter
of the line between elements.

This looks wrong at the end of the tree when trying to add a page
below the last child, so we add a condition to show the line at
the bottom for the last child of the tree in that case.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Andreas Nedbal uploaded patch set 1 05/13/23, 11:38

  2. core-ci voted on patch set 1 V +1 05/13/23, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41796

  3. Torben Hansen voted on patch set 1 V +1 CR +1 05/20/23, 10:51

  4. Jasmina Ließmann voted on patch set 1 V +1 CR +1 06/07/23, 08:44

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 06/08/23, 11:00

  6. Christian Kuhn merged patch set 2 06/08/23, 11:00