Review main Merged

79060[BUGFIX] Make symfony console handle exceptions again

Torben Hansen CR +2 V +2 Easy +0 −1 updated 06/27/23, 05:02

Commit message

With #99912 it has been configured that exceptions in CLI context
are not catched any more by symfony console. This change however
has the following downsides:

* CLI now throws all exceptions, which does not look pretty
* Possible user errors (e.g. unknown command or invalid amount of
  arguments) are also thrown as exception and are now logged to
  the TYPO3 log including sys_log
* Symfony command auto-suggestion for commands does not work any more

This patch therefore reverts the change made in #99912 to restore
the original functionality.

Applications requiring to process exceptions thrown by CLI commands
should implement an event listen for the `ConsoleErrorEvent`.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1