79061[TASK] Provide path to exception message in PathUtility
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2024
-
Georg Ringer uploaded patch set 1 05/17/23, 05:54
-
Georg Ringer commented on patch set 1 05/17/23, 05:54
This change is ready for review. -
core-ci voted on patch set 1 V +1 05/17/23, 06:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41882
-
Benni Mack commented on patch set 1 05/17/23, 08:09
PathUtility.php:100is this showing the full path from the file system? -
Georg Ringer commented on patch set 1 05/17/23, 08:17
no, I had this with a project having as Backend logo something like "/fileadmin/fo/logo.png" which works fine for BE login but failed with system mails because logo could not be retrieved -
Markus Klein updated the commit message in patch set 2
V +105/17/23, 08:54 -
core-ci voted on patch set 2 V +1 05/17/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41888
-
Oliver Klee voted on patch set 2 CR +1 05/17/23, 10:05
-
Stefan Froemken commented on patch set 2 CR -1 05/22/23, 08:24
PathUtility.php:100Start sentence with capital "Given: ". Personally, I would prefer: "Given path: " -
Georg Ringer uploaded patch set 3
CR +1V +110/09/23, 18:22 -
Georg Ringer commented on patch set 2 10/09/23, 18:24
PathUtility.php:100Replyno, it is e.g.: Given file "EXT:core/Resources/Public/JavaScript/java-script-item-handler.js" is expected to be in public directory, but is not -
core-ci voted on patch set 3 V +1 10/09/23, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47617
-
Stefan Bürk commented on patch set 3 10/09/23, 20:50
PathUtility.php:100ReplyThat's not correct Georg. `isExtensionPath()` checks if the $resourcePath starts with 'EXT:', and if not this exception is thrown. That means, this exception now exposes everything provided to $resourcePath in general not starting with an 'EXT:' prefix. And eventually exposes full patchs. getFileAbsFileName() would handle `absolute` paths and checkinbg them to beeing beneath a extension folder. Not sure about that. -
Georg Ringer commented on patch set 3 10/10/23, 04:38
PathUtility.php:100Replythe big question is: in production context, the exception is not shown anyway ... i got no problem with discarding the change -
Oliver Hader updated the commit message in patch set 4
V +110/18/24, 14:10 -
Christian Kuhn commented on patch set 4 01/14/25, 15:01
PathUtility.php:100Replyi brought this change to the attention of the security team today, asking if revealing a 'full path' in an exception message is ok or not. -
Christian Kuhn commented on patch set 4 01/27/25, 13:17
PathUtility.php:100ReplySec team: "It’s okay, if it’s just in development context - but not exposed in production context." My understanding of the error/exception handling is: Exception messages are not rendered in correctly configured production setups. I'll set this resolved and will push this issue forward. -
Christian Kuhn uploaded patch set 5 01/27/25, 13:22
-
Christian Kuhn commented on patch set 4 CR +1 V +1 01/27/25, 13:22
PathUtility.php:100Replyrephrased. -
Christian Kuhn voted on patch set 5 CR +1 V +1 01/27/25, 13:23
-
core-ci voted on patch set 5 V +1 01/27/25, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/73054
-
Oliver Klee wrote 01/27/25, 15:24
Removed reviewer Oliver Klee. -
Benni Mack voted on patch set 5 CR +2 V +2 01/27/25, 17:02
-
Benni Mack merged patch set 6 01/27/25, 17:02