Review main Merged

79067[TASK] Remove jquery & jquery-ui from image manipulation

Oliver Hader CR +2 V +2 Expert +673 −416 updated 06/06/23, 07:51

Commit message

This change removes jquery and jquery-ui from the image
manipulation widget. The draggable & resizable features
have been reimplemented in a new dedicated lit-element
`<typo3-backend-draggable-resizable>`, which emits the
following events (having `action` and `originOffset`):

 + @draggable-resizable-start
 + @draggable-resizable-update
 + @draggable-resizable-finish

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 2337

Show 712 earlier messages
  1. Oliver Hader uploaded patch set 1 05/17/23, 18:15

  2. core-ci voted on patch set 1 V +1 05/17/23, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41898

  3. Oliver Hader uploaded patch set 2 V +1 05/19/23, 13:45

  4. core-ci voted on patch set 2 V +1 05/19/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41926

  5. Oliver Hader uploaded patch set 3 V +1 06/02/23, 14:49

  6. core-ci voted on patch set 3 V -1 06/02/23, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42163

  7. Oliver Hader uploaded patch set 4 V -1 06/02/23, 15:03

  8. core-ci voted on patch set 4 V -1 06/02/23, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42164

  9. Oliver Hader uploaded patch set 5 V -1 06/03/23, 10:14

  10. core-ci voted on patch set 5 V -1 06/03/23, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42184

  11. Oliver Hader uploaded patch set 6 V -1 06/03/23, 10:23

  12. Oliver Hader uploaded patch set 7 06/03/23, 10:29

  1. core-ci voted on patch set 6 V -1 06/03/23, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42185

  2. core-ci voted on patch set 7 V +1 06/03/23, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42186

  3. Oliver Hader uploaded patch set 8 V +1 06/03/23, 11:04

  4. core-ci voted on patch set 8 V +1 06/03/23, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42187

  5. Oliver Hader uploaded patch set 9 V +1 06/03/23, 11:15

  6. core-ci voted on patch set 9 V +1 06/03/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42188

  7. Oliver Hader uploaded patch set 10 V +1 06/03/23, 19:56

  8. Oliver Hader uploaded patch set 11 06/03/23, 20:01

  9. core-ci voted on patch set 10 V +1 06/03/23, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42189

  10. Oliver Hader commented on patch set 10 06/03/23, 20:05

    This change is ready for review.
    Find out which other magic was updating the form engine view...

    image-manipulation.ts:697

    Actually use `<=`

    image-manipulation.ts:719

    Check this again
  11. Oliver Hader marked it ready for review 06/03/23, 20:05

  12. Oliver Hader marked it work in progress 06/03/23, 20:05

  13. core-ci voted on patch set 11 V +1 06/03/23, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42190

  14. Oliver Hader uploaded patch set 12 V +1 06/04/23, 21:59

  15. Oliver Hader commented on patch set 11 06/04/23, 22:02

    This change is ready for review.

    Reply

    Done

    image-manipulation.ts:697 Reply

    kept it

    image-manipulation.ts:719 Reply

    Done
  16. Oliver Hader marked it ready for review 06/04/23, 22:02

  17. core-ci voted on patch set 12 V +1 06/04/23, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42198

  18. Oliver Hader uploaded patch set 13 V +1 06/04/23, 22:12

  19. core-ci voted on patch set 13 V +1 06/04/23, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42199

  20. Oliver Hader uploaded patch set 14 V +1 06/05/23, 14:34

  21. core-ci voted on patch set 14 V +1 06/05/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42219

  22. Benni Mack voted on patch set 14 V +1 CR +1 06/05/23, 15:18

  23. Stefan Bürk voted on patch set 14 V +1 CR +1 06/05/23, 19:50

  24. Oliver Hader commented on patch set 14 V +2 CR +2 06/06/23, 07:51

    Thx folks!
  25. Oliver Hader merged patch set 15 06/06/23, 07:51