Review main Abandoned

79068[BUGFIX] Allow copying spam protected email addresses

Jan Schär CR 0 V 0 Easy +4 −7 updated 10/14/23, 12:39

Commit message

Fix spam protected email links to that they can be copied from the
context menu. Alternatively, a contextmenu handler could be added,
but that solution does not work on Firefox for Android.

This improves usability while slightly reducing spam protection.
However, I believe it would be more likely that spammers specifically
target the data-mailto-token attributes rather than going through the
effort of running pages in a headless browser.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Jan Schär uploaded patch set 1 05/18/23, 16:12

  2. core-ci voted on patch set 1 V +1 05/18/23, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41908

  3. Andreas Kienast commented on patch set 1 V -1 CR -1 07/05/23, 09:39

    Thank you for your patch. Unfortunately, this patch basically disables the whole spam protection as the href attributes get decrypted on load. Today's bots usually execute JavaScript, eliminating the benefit of this feature.
  4. Jan Schär abandoned the change 10/14/23, 12:39

    Maintainer believes that this change would make the anti-spam measure ineffective.