79092[TASK] Remove usages of QueryBuilder::resetQueryParts
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 45
-
Anja Leichsenring uploaded patch set 1 05/19/23, 04:22
-
core-ci voted on patch set 1 V +1 05/19/23, 04:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41922
-
Oliver Klee voted on patch set 1 V +1 CR +1 05/19/23, 07:07
-
Stefan Bürk commented on patch set 1 V +2 CR +2 05/19/23, 09:27
Small addition. It have been recommended always to not reuse a QueryBuilder instance, and have been documented as such as "INFO" for example here: https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Database/QueryBuilder/Index.html So, this do not only prepare the upgrade but also removes a violation of the core against own recommendations. Thanks Anja for taking care of this. -
Stefan Bürk merged patch set 2 05/19/23, 09:27