Review main Merged

79135[TASK] Remove usage of QueryBuilder::resetQueryPart() form ext:redirects

Anja Leichsenring CR +2 V +2 Normal +76 −17 updated 05/31/23, 07:57

Commit message

Doctrine 4 will no longer provide access to SQL query parts, so we need
to adjust our internal usages to cope with this change. The strategy
by rule of thumb involves to not reuse queryBuilder instances, so
no reset must happen anyway.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Anja Leichsenring uploaded patch set 1 05/23/23, 13:31

  2. core-ci voted on patch set 1 V -1 05/23/23, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41980

  3. Anja Leichsenring uploaded patch set 2 V -1 05/24/23, 03:50

  4. core-ci voted on patch set 2 V +1 05/24/23, 03:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41989

  5. Nikita Hovratov voted on patch set 2 CR +1 05/24/23, 18:33

  6. Jörg Bösche voted on patch set 2 CR +1 05/26/23, 13:05

  7. Nikita Hovratov uploaded patch set 3 CR +1 V +1 05/27/23, 01:25

  8. core-ci voted on patch set 3 V +1 05/27/23, 01:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42053

  9. Nikita Hovratov voted on patch set 3 V +1 CR +1 05/27/23, 01:35

  10. Stefan Bürk updated the commit message in patch set 4 CR +1 V +1 05/31/23, 07:36

  11. Nikita Hovratov voted on patch set 4 V +1 CR +1 05/31/23, 07:38

  12. core-ci voted on patch set 4 V +1 05/31/23, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42104

  13. Stefan Bürk voted on patch set 4 V +2 CR +2 05/31/23, 07:57

  14. Stefan Bürk merged patch set 5 05/31/23, 07:57