Review main Merged

79136[BUGFIX] Show source file and user agent in CSP backend module

Oliver Hader CR +2 V +2 Hard +224 −72 updated 06/29/23, 15:26

Commit message

The CSP backend module is not showing the optional source-file
of the reported violation. This information references to the
actual asset that caused the violation. In addition, visualizing
the user-agent helps to identifiy and reproduce possible flaws.

In case, `effective-directive` (preferred W3C property) is not
given, but `violated-directive` (legacy W3C property) is, that
value is taken - this still can happen in old browser versions.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 1118

  1. Oliver Hader uploaded patch set 1 05/23/23, 15:02

  2. Oliver Hader updated the commit message in patch set 2 05/23/23, 15:07

  3. core-ci voted on patch set 1 V +1 05/23/23, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41981

  4. core-ci voted on patch set 2 V +1 05/23/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41982

  5. Oliver Hader marked it work in progress 05/23/23, 22:14

  6. Oliver Hader uploaded patch set 3 V +1 05/23/23, 22:27

  7. Oliver Hader marked it ready for review 05/23/23, 22:27

  8. core-ci voted on patch set 3 V -1 05/23/23, 22:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41984

  9. Oliver Hader uploaded patch set 4 V -1 05/23/23, 22:47

  10. core-ci voted on patch set 4 V +1 05/23/23, 22:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41985

  11. Oliver Hader uploaded patch set 5 V +1 06/01/23, 09:24

  12. core-ci voted on patch set 5 V +1 06/01/23, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42140

  13. Oliver Hader rebased onto patch set 6 V +1 06/26/23, 08:38

  14. core-ci voted on patch set 6 V +1 06/26/23, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42979

  15. Oliver Hader rebased onto patch set 7 V +1 06/29/23, 15:00

  16. core-ci voted on patch set 7 V +1 06/29/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43119

  17. Oliver Hader voted on patch set 7 V +2 CR +2 06/29/23, 15:25

  18. Oliver Hader merged patch set 8 06/29/23, 15:26