Review main Merged

79138[TASK] Avoid QueryBuilder::resetQueryPart() in ext:indexed_search

Anja Leichsenring CR +2 V +2 Easy +11 −10 updated 06/08/23, 14:26

Commit message

Doctrine 4 will no longer provide access to SQL query parts,
so we need to adjust our internal usages to cope with this
change. The strategy by rule of thumb involves to not reuse
queryBuilder instances, so no reset must happen anyway.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Anja Leichsenring uploaded patch set 1 05/24/23, 04:16

  2. core-ci voted on patch set 1 V +1 05/24/23, 04:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41993

  3. Jörg Bösche voted on patch set 1 CR +1 05/26/23, 13:05

  4. Stefan Bürk uploaded patch set 2 CR +1 V +1 06/08/23, 14:18

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 06/08/23, 14:22

  6. core-ci voted on patch set 2 V +1 06/08/23, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42311

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 06/08/23, 14:26

  8. Stefan Bürk merged patch set 3 06/08/23, 14:26