Review main Merged

79142[TASK] Raise guzzlehttp/promises to v2

Nikita Hovratov CR +2 V +2 Normal +33 −36 updated 06/01/23, 07:11

Commit message

The update brings PHP 7 typehints to guzzlehttp/promises.
guzzlehttp/guzzle mainly raised for guzzlehttp/promises v2
compatibility, but also contains a bugfix for SetCookie::fromString.

> composer require -W guzzlehttp/guzzle:^7.7.0
> composer require guzzlehttp/promises:^2.0
> composer require --no-update guzzlehttp/promises:^2.0 \
  -d typo3/sysext/install/
> composer require --no-update guzzlehttp/guzzle:^7.7.0 \
  -d typo3/sysext/core/

- Upgrading guzzlehttp/guzzle (7.5.1 => 7.7.0)
- Upgrading guzzlehttp/promises (1.5.3 => 2.0.0)

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1116

  1. Nikita Hovratov uploaded patch set 1 05/24/23, 19:25

  2. core-ci voted on patch set 1 V -1 05/24/23, 19:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42004

  3. Nikita Hovratov updated the commit message in patch set 2 V -1 05/24/23, 20:06

  4. Nikita Hovratov uploaded patch set 3 05/24/23, 20:07

  5. core-ci voted on patch set 3 V -1 05/24/23, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42007

  6. core-ci voted on patch set 2 V -1 05/24/23, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42006

  7. Nikita Hovratov rebased onto patch set 4 V -1 05/26/23, 07:21

  8. core-ci voted on patch set 4 V +1 05/26/23, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42046

  9. Oliver Klee voted on patch set 4 V +1 CR +1 05/26/23, 08:27

  10. Nikita Hovratov uploaded patch set 5 CR +1 V +1 05/31/23, 20:26

  11. core-ci voted on patch set 5 V +1 05/31/23, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42121

  12. Georg Ringer voted on patch set 5 V +1 CR +1 06/01/23, 03:34

  13. Benni Mack commented on patch set 5 V +1 CR +1 06/01/23, 07:03

    For v11 I would recommend using a more lax restriction (basically allowing ^1.5 || ^2.0 for promises), as some people reported in the past that their applications were unable to update then.
  14. Nikita Hovratov commented on patch set 5 06/01/23, 07:07

    Reply

    Ok.
  15. Nikita Hovratov voted on patch set 5 V +2 CR +2 06/01/23, 07:10

  16. Nikita Hovratov merged patch set 6 06/01/23, 07:11