Review main Merged

79143[BUGFIX] Fix phpstan finding in Clipboard

Nikita Hovratov CR +2 V +2 Easy +4 −9 updated 06/01/23, 10:04

Commit message

The parent folder could theoretically be an InaccessibleFolder
according to the return type annotation, but only Folder has the method
"getCombinedIdentifier".

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oli Bartsch +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Nikita Hovratov uploaded patch set 1 05/24/23, 20:02

  2. core-ci voted on patch set 1 V +1 05/24/23, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42005

  3. Oliver Hader commented on patch set 1 06/01/23, 08:58

    Clipboard.php:311

    I guess it might happen, that `titleLen` is not set in `UC`? e.g. `(int)($this->getBackendUser()->uc['titleLen'] ?? 0)` instead
  4. Oli Bartsch uploaded patch set 2 V +1 06/01/23, 09:08

  5. Oli Bartsch commented on patch set 2 V +1 CR +1 06/01/23, 09:09

    Clipboard.php:311 Reply

    Done
  6. core-ci voted on patch set 2 V +1 06/01/23, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42138

  7. Nikita Hovratov commented on patch set 2 06/01/23, 09:18

    Clipboard.php:311 Reply

    thanks!
  8. Oliver Hader voted on patch set 2 V +1 CR +1 06/01/23, 09:56

  9. Nikita Hovratov voted on patch set 2 V +2 CR +2 06/01/23, 10:00

  10. Nikita Hovratov merged patch set 3 06/01/23, 10:04