Review main Merged

79149[TASK] Slim down php-cs-fixer configuration file

Benni Mack CR +2 V +2 Easy +3 −11 updated 06/05/23, 18:49

Commit message

TYPO3 uses PER standard definitions and some more additions
when it comes to PHP Coding guidelines.

However, the main config file of TYPO3 defines some configuration
options which are already in PSR-12 RuleSet (which is the current PER definition)
see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.17.0/src/RuleSet/Sets/PSR12Set.php
which can be removed.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Benni Mack uploaded patch set 1 05/27/23, 22:40

  2. core-ci voted on patch set 1 V +1 05/27/23, 22:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42061

  3. Oliver Klee commented on patch set 1 05/28/23, 12:21

    config.php:35

    As we are not directly referencing PSR12 in the configuration below, I propose dropping it from the comment as well and only keep PER to avoid confusing the reader.
  4. Simon Gilli commented on patch set 1 CR -1 05/31/23, 12:08

    config.php:86

    Should be 'ordered_imports' => ['sort_algorithm' => 'alpha'] because PER does specify the imports_order only see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/master/doc/rules/import/ordered_imports.rst#rule-sets
  5. Benni Mack uploaded patch set 2 CR -1 V +1 06/04/23, 20:17

  6. core-ci voted on patch set 2 V +1 06/04/23, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42197

  7. Benni Mack commented on patch set 3 V +1 06/05/23, 06:18

    Published edit on patch set 2.
  8. Benni Mack commented on patch set 3 06/05/23, 06:18

    config.php:35 Reply

    Done

    config.php:86 Reply

    Done
  9. core-ci voted on patch set 3 V +1 06/05/23, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42205

  10. Oliver Klee voted on patch set 3 V +1 06/05/23, 12:42

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 06/05/23, 14:29

  12. Stefan Bürk voted on patch set 3 V +2 CR +2 06/05/23, 18:49

  13. Stefan Bürk merged patch set 4 06/05/23, 18:49