Review 12.4 Merged

79156[TASK] Raise guzzlehttp/promises to v2

Nikita Hovratov CR +2 V +2 Normal +33 −36 updated 06/28/23, 07:08

Commit message

The update brings PHP 7 typehints to guzzlehttp/promises.
guzzlehttp/guzzle mainly raised for guzzlehttp/promises v2
compatibility, but also contains a bugfix for SetCookie::fromString.

> composer require -W guzzlehttp/guzzle:^7.7.0
> composer require guzzlehttp/promises:^2.0
> composer require --no-update guzzlehttp/promises:^2.0 \
  -d typo3/sysext/install/
> composer require --no-update guzzlehttp/guzzle:^7.7.0 \
  -d typo3/sysext/core/

- Upgrading guzzlehttp/guzzle (7.5.1 => 7.7.0)
- Upgrading guzzlehttp/promises (1.5.3 => 2.0.0)

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 67

  1. Nikita Hovratov uploaded patch set 1 06/01/23, 07:17

  2. core-ci voted on patch set 1 V +1 06/01/23, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42130

  3. Nikita Hovratov voted on patch set 1 V +2 CR +2 06/01/23, 07:29

  4. Nikita Hovratov merged patch set 2 06/01/23, 07:30

  5. Oliver Hader voted on patch set 2 CR +1 06/28/23, 07:05

  6. Oliver Hader commented on patch set 2 06/28/23, 07:07

    Comment removed by: Oliver Hader; Reason: wrong reference
  7. Oliver Hader commented on patch set 2 06/28/23, 07:08