Review main Merged

79160[TASK] Remove obsolete `composer/package-versions-deprecated`

Stefan Bürk CR +2 V +2 Normal +1 −76 updated 06/02/23, 11:10

Commit message

Package `composer/package-versions-deprecated` is required
as development dependency in the root composer.json. That
package itself is deprecated and it is recommended to use
class `Composer\InstalledVersions` directly with composer 2+
only support.

TYPO3 requires composer v2.x as a minimum since TYPO3 v11,
so there is no need to keep this development dependency
installed. It's not used anyway in the development cycle.

Used command(s):

> composer remove --dev "composer/package-versions-deprecated"
> composer config --unset \
    allow-plugins.composer/package-versions-deprecated

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Stefan Bürk uploaded patch set 1 06/01/23, 10:57

  2. core-ci voted on patch set 1 V +1 06/01/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42148

  3. Oliver Klee voted on patch set 1 V +1 CR +1 06/01/23, 11:27

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 06/02/23, 07:42

  5. Georg Ringer voted on patch set 1 V +2 CR +2 06/02/23, 11:10

  6. Georg Ringer merged patch set 2 06/02/23, 11:10