Review main Merged

79164[DOCS] List PSR-14 events in workspaces documentation

Chris Müller CR +2 V +2 Normal +52 −0 updated 06/21/23, 10:03

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1214

  1. Chris Müller uploaded patch set 1 06/02/23, 18:46

  2. core-ci voted on patch set 1 V +1 06/02/23, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42170

  3. Sybille Peters commented on patch set 1 06/03/23, 08:56

    Index.rst:12

    Cool, I see that you link to the already existing list in the "TYPO3 Explained": https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Events/Events/Index.html I find this helpful. However, the original text in "TYPO3 Explained" is "Used in the workspaces module to find all chacheable data of versions of a workspace." and here it is "Find all cacheable data of versions of a workspace". I think it is helpful to have the context "Used in the workspace module" so I would use the original text (apart from the typo). Events related to workspaces may also get dispatched elsewhere. This does not seem to be the case currently, but might in the future.
  4. Lina Wolf voted on patch set 1 V +1 CR +1 06/03/23, 08:58

  5. Sybille Peters commented on patch set 1 06/03/23, 09:06

    You have tagged this as TASK, the other patch is DOCS: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79069?usp=search No biggie, but perhaps it should be DOCS here as well.
  6. Chris Müller commented on patch set 1 06/03/23, 18:01

    Reply

    The other one has no "documentation" in the commit message, therefore I chose DOCS. This one has. As we don't have a DOCS part in the issue tracker, this should not matter.

    Index.rst:12 Reply

    There is already a PR which fixes this typo. Revised the whole events list in TYPO3 Explained, also the workspaces part.
  7. Sybille Peters voted on patch set 1 V +1 CR +1 06/04/23, 07:37

  8. Chris Müller commented on patch set 1 V -1 06/04/23, 18:05

    Perhaps we will move the detailled documentation of the events into the extension docs. Blocking for now.
  9. Chris Müller commented on patch set 1 V 0 06/20/23, 16:19

    Let's get this in for now ...
  10. Chris Müller updated the commit message in patch set 2 CR +1 V +1 06/20/23, 16:20

  11. core-ci voted on patch set 2 V +1 06/20/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42835

  12. Benni Mack voted on patch set 2 V +1 CR +1 06/20/23, 21:22

  13. Christian Kuhn voted on patch set 2 V +2 CR +2 06/21/23, 10:03

  14. Christian Kuhn merged patch set 3 06/21/23, 10:03