Review 12.4 Merged

79175[BUGFIX] Allow ViewHelpers from libraries

Stefan Bürk CR +2 V +2 Normal +97 −86 updated 06/05/23, 19:09

Commit message

With TYPO3 11 it was possible to use ViewHelpers from composer libraries
that aren't TYPO3 extensions and thus don't use Symfony dependency
injection. With the removal of objectManager, this doesn't work anymore
in TYPO3 12 because the dependency injection can only instantiate
ViewHelper classes that are defined as public services explicitly.

This change reintroduces that functionality by falling back to "new" if
the class exists but isn't registered as a service. Fluid standalone
uses the same method to instantiate a ViewHelper.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 34

  1. Stefan Bürk commented on patch set 1 06/05/23, 18:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 06/05/23, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42223

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 06/05/23, 19:09

  4. Stefan Bürk merged patch set 2 06/05/23, 19:09