Review main Merged

79208[FEATURE] Make autocomplete selectable in the backend

Lina Wolf CR +2 V +2 Nightmare +1792 −1078 updated 06/20/23, 14:43

Commit message

Autocomplete options can already be added to input
fields in form via editing the YAML. This is
however hard or impossible to do for editors.

Where ever applicable the autocomplete tag has to
be set on form inputs to be accessibility
compliant, however.

The parameter can have arbitrary content according
to the HTML standard. However, assistive
technology only supports a finite number of values,
of which only few are commonly used in contact
forms.

Projects that desire additional parameter values
can set them via YAML.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 2027

Show 2 earlier messages
  1. Lina Wolf uploaded patch set 1 06/07/23, 15:36

  2. Lina Wolf updated the commit message in patch set 2 06/07/23, 15:39

  1. core-ci voted on patch set 1 V +1 06/07/23, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42276

  2. core-ci voted on patch set 2 V +1 06/07/23, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42277

  3. Michael Telgkamp commented on patch set 2 CR -1 06/07/23, 19:34

    Thank you for the patch, I have added some remarks.

    Number.yaml:58

    Typo, should be `address-line2`

    RadioButton.yaml:82

    tel-national is the "Telephone number without the county code component, with a country-internal prefix applied if applicable". This does not make sense for RadioButton in my opinion.

    Url.yaml:46

    I would suggest to add `url` here, too.
  4. Björn Jacob commented on patch set 2 CR -1 06/08/23, 06:07

    Can you please also take care of the documentation. I highly suggest to have it in one patch. Thanks!
  5. Lina Wolf uploaded patch set 3 CR -1 V +1 06/08/23, 07:34

  6. Lina Wolf commented on patch set 3 06/08/23, 07:36

    Number.yaml:58 Reply

    Exchanged it

    RadioButton.yaml:82 Reply

    replaced it with tel-country-code

    Url.yaml:46 Reply

    Done
  7. core-ci voted on patch set 3 V +1 06/08/23, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42286

  8. Elias Häußler commented on patch set 3 06/08/23, 07:56

    I'd say this is more a feature than a task, because we're adding new functionality to the form editor and its configuration. In addition, I'm not sure if adding new numeric keys to existing EXT:form configurations may be breaking in cases where those keys are already configured in projects. In such cases, configurations will be merged and the resulting configuration is probably not desired. What do you think? How did we handle this in the past?
  9. Michael Telgkamp commented on patch set 3 06/08/23, 08:03

    To improve the quality and correct usage of this attribute, a description on the field would be helpful. The description should include, that autocomplete is only intended for personal information of the current visitor.
  10. Björn Jacob commented on patch set 3 06/08/23, 08:32

    Reply

    This is indeed a problem. This is nothing I would add to v12. Main only. It is a feature. It needs documentation, a feature rst, and it is IMHO breaking. I would use the keys but mark it as potentially breaking - for something good.
  11. Lina Wolf uploaded patch set 4 V +1 06/08/23, 09:42

  12. Lina Wolf commented on patch set 4 06/08/23, 09:44

    Reply

    I believe you are right, I will remove the 12.4 goal and add a feature-rst

    Reply

    I added descriptions of the values, Please have another look
  13. core-ci voted on patch set 4 V +1 06/08/23, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42288

  14. Lina Wolf uploaded patch set 5 V +1 06/08/23, 09:52

  15. Lina Wolf updated the commit message in patch set 6 06/08/23, 09:52

  16. Lina Wolf commented on patch set 6 06/08/23, 09:54

    Reply

    I don't think this feature is breaking. When installations already defined these keys in their own configurations the additional configuration will override the default one provided by this extension. They might - however - not see the new feature.
  17. core-ci voted on patch set 6 V +1 06/08/23, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42290

  18. core-ci voted on patch set 5 V +1 06/08/23, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42289

  19. Anja Leichsenring voted on patch set 6 V +1 CR +1 06/12/23, 04:54

  20. Michael Telgkamp uploaded patch set 7 CR +1 V +1 06/15/23, 14:34

  21. Michael Telgkamp commented on patch set 7 V +1 CR +1 06/15/23, 14:36

    After adding the changes to the example form everything looks good to me.
  22. core-ci voted on patch set 7 V +1 06/15/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42666

  23. Oliver Klee voted on patch set 7 CR +1 06/15/23, 15:58

  24. Benni Mack voted on patch set 7 V +2 CR +2 06/20/23, 14:43

  25. Benni Mack merged patch set 8 06/20/23, 14:43