79208[FEATURE] Make autocomplete selectable in the backend
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Benni Mack +2
- Michael Telgkamp +1
- core-ci +1 CI
Issues 1
Files 29
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-88817-MakeAutocompleteSelectableInTheBackend.rstnew+40 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/AdvancedPassword.yaml+19 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Checkbox.yaml+22 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/CountrySelect.yaml+19 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Date.yaml+16 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/DatePicker.yaml+16 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Email.yaml+16 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/FileUpload.yaml+16 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Hidden.yaml+13 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Honeypot.yaml+13 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/ImageUpload.yaml+17 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiCheckbox.yaml+22 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiSelect.yaml+22 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Number.yaml2+25 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Password.yaml+19 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/RadioButton.yaml2+31 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/SingleSelect.yaml+31 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Telephone.yaml+31 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml+73 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Textarea.yaml+16 −0
Show 9 more files
- typo3/sysext/form/Configuration/Yaml/FormElements/Url.yaml2+19 −0
- typo3/sysext/form/Documentation/E/Accessibility/Index.rstnew+46 −0
- typo3/sysext/form/Documentation/E/Index.rst+7 −7
- typo3/sysext/form/Documentation/I/Concepts/Autocomplete/Index.rstnew+34 −0
- typo3/sysext/form/Documentation/I/Concepts/Autocomplete/_CustomFormSetupAutoCompleteOption.yamlnew+11 −0
- typo3/sysext/form/Documentation/I/Concepts/Autocomplete/_setup.typoscriptnew+9 −0
- typo3/sysext/form/Documentation/I/Concepts/Index.rst+15 −15
- typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Yaml/NewForms/SimpleContactForm.yaml+3 −1
- typo3/sysext/form/Resources/Private/Language/Database.xlf+1171 −1055
Review log 2027
Show 2 earlier messages
-
core-ci voted on patch set 1 V +1 06/07/23, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42276
-
core-ci voted on patch set 2 V +1 06/07/23, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42277
-
Michael Telgkamp commented on patch set 2 CR -1 06/07/23, 19:34
Thank you for the patch, I have added some remarks.Number.yaml:58Typo, should be `address-line2`RadioButton.yaml:82tel-national is the "Telephone number without the county code component, with a country-internal prefix applied if applicable". This does not make sense for RadioButton in my opinion.Url.yaml:46I would suggest to add `url` here, too. -
Björn Jacob commented on patch set 2 CR -1 06/08/23, 06:07
Can you please also take care of the documentation. I highly suggest to have it in one patch. Thanks! -
Lina Wolf uploaded patch set 3
CR -1V +106/08/23, 07:34 -
Lina Wolf commented on patch set 3 06/08/23, 07:36
Number.yaml:58ReplyExchanged itRadioButton.yaml:82Replyreplaced it with tel-country-codeUrl.yaml:46ReplyDone -
core-ci voted on patch set 3 V +1 06/08/23, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42286
-
Elias Häußler commented on patch set 3 06/08/23, 07:56
I'd say this is more a feature than a task, because we're adding new functionality to the form editor and its configuration. In addition, I'm not sure if adding new numeric keys to existing EXT:form configurations may be breaking in cases where those keys are already configured in projects. In such cases, configurations will be merged and the resulting configuration is probably not desired. What do you think? How did we handle this in the past? -
Michael Telgkamp commented on patch set 3 06/08/23, 08:03
To improve the quality and correct usage of this attribute, a description on the field would be helpful. The description should include, that autocomplete is only intended for personal information of the current visitor. -
Björn Jacob commented on patch set 3 06/08/23, 08:32
Reply
This is indeed a problem. This is nothing I would add to v12. Main only. It is a feature. It needs documentation, a feature rst, and it is IMHO breaking. I would use the keys but mark it as potentially breaking - for something good. -
Lina Wolf uploaded patch set 4
V +106/08/23, 09:42 -
Lina Wolf commented on patch set 4 06/08/23, 09:44
Reply
I believe you are right, I will remove the 12.4 goal and add a feature-rstReply
I added descriptions of the values, Please have another look -
core-ci voted on patch set 4 V +1 06/08/23, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42288
-
Lina Wolf uploaded patch set 5
V +106/08/23, 09:52 -
Lina Wolf updated the commit message in patch set 6 06/08/23, 09:52
-
Lina Wolf commented on patch set 6 06/08/23, 09:54
Reply
I don't think this feature is breaking. When installations already defined these keys in their own configurations the additional configuration will override the default one provided by this extension. They might - however - not see the new feature. -
core-ci voted on patch set 6 V +1 06/08/23, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42290
-
core-ci voted on patch set 5 V +1 06/08/23, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42289
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 06/12/23, 04:54
-
Michael Telgkamp uploaded patch set 7
CR +1V +106/15/23, 14:34 -
Michael Telgkamp commented on patch set 7 V +1 CR +1 06/15/23, 14:36
After adding the changes to the example form everything looks good to me. -
core-ci voted on patch set 7 V +1 06/15/23, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42666
-
Oliver Klee voted on patch set 7 CR +1 06/15/23, 15:58
-
Benni Mack voted on patch set 7 V +2 CR +2 06/20/23, 14:43
-
Benni Mack merged patch set 8 06/20/23, 14:43