Review 12.4 Merged

79232[BUGFIX] Properly align positioning line at the end of tree

Christian Kuhn CR +2 V +2 Easy +8 −2 updated 06/08/23, 11:01

Commit message

The positioning line is always shown above elements, regardless
of dragging position. This is most likely done to prevent jitter
of the line between elements.

This looks wrong at the end of the tree when trying to add a page
below the last child, so we add a condition to show the line at
the bottom for the last child of the tree in that case.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 06/08/23, 10:52

  2. core-ci voted on patch set 1 V +1 06/08/23, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42295

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 06/08/23, 11:00

  4. Christian Kuhn merged patch set 2 06/08/23, 11:01