79234[TASK] Avoid expensive preg_match calls in addHash method
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1014
-
Alexander Schnitzler uploaded patch set 1 06/08/23, 11:21
-
core-ci voted on patch set 1 V -1 06/08/23, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42297
-
Alexander Schnitzler uploaded patch set 2
V -106/08/23, 19:30 -
core-ci voted on patch set 2 V -1 06/08/23, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42322
-
Oliver Hader commented on patch set 2 06/27/23, 12:19
-
Oliver Hader uploaded patch set 3
V -106/27/23, 12:56 -
Oliver Hader commented on patch set 3 06/27/23, 12:59
With hashing all parameters, processing time might be faster - however, memory consumption would increase. Anyway, I've adjusted the patch - test should be green again.VariableProcessor.php:41Reply... -
core-ci voted on patch set 3 V -1 06/27/23, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43030
-
Oliver Hader uploaded patch set 4
V -106/27/23, 13:27 -
Oliver Hader commented on patch set 4 06/27/23, 13:29
Reply Unresolved
Adjusted the unit-tests as well - basically nobody would understand that anymore, debugging in `VariableProcessor` becomes more challenging with this patch. Alternative: Just use a check whether a hash has already created in `addHash()`. -
core-ci voted on patch set 4 V -1 06/27/23, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43031
-
Oliver Hader commented on patch set 4 06/27/23, 14:48
The title of the forge issue was outlining an alternative approach. I've created an alternative patch that uses a shared runtime cache - this way, the necessity to hash and the hash-sum of a value are only processed once for each value. → https://review.typo3.org/c/Packages/TYPO3.CMS/+/79522 -
Alexander Schnitzler commented on patch set 4 07/06/23, 09:43
Reply
Thank you very much! I will benchmark my project without and with your patch next week. -
Alexander Schnitzler abandoned the change 07/06/23, 09:43
Not needed any more.
VariableProcessor.php:41