Review main Abandoned

79374[BUGFIX] Show unsaved changes popup when changing languages

Krzysztof Gutkowski CR 0 V 0 Normal +116 −26 updated 07/07/23, 08:46

Commit message

When handling language changes in the editor, GlobalEventHandler would
only navigate to the page with the changed language, without checking
if there are any unsaved changes.

This commit makes FormEngine catch the appropriate event, and check
for display the unsaved changes popup if necessary before navigating
to the new page.

Since saving involves a POST request to EditDocumentController, a param
_saveandchangelanguage has been added, that, if exists in parsedBody,
will cause the controller to redirect to the changed language page.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 58

  1. Krzysztof Gutkowski uploaded patch set 1 06/14/23, 16:04

  2. core-ci voted on patch set 1 V -1 06/14/23, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42585

  3. Krzysztof Gutkowski uploaded patch set 2 V -1 06/14/23, 16:17

  4. core-ci voted on patch set 2 V +1 06/14/23, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42586

  5. Stefan Bürk commented on patch set 2 06/20/23, 01:37

  6. Andreas Kienast uploaded patch set 3 V +1 07/07/23, 08:06

  7. core-ci voted on patch set 3 V +1 07/07/23, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43862

  8. Andreas Kienast abandoned the change 07/07/23, 08:46

    Thank you for your patch. We're abandoning it in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/77719 as it solves the issue on a broader scope.