Review main Merged

79402[BUGFIX] Flush fluid cache when switching debug output in AdminPanel

Krzysztof Gutkowski CR +2 V +2 Easy +40 −1 updated 07/04/23, 19:55

Commit message

Currently, when switching the 'Show fluid debug output' in AdminPanel,
the relevant frontend caches weren't flushed, causing pages to be
rendered using the old ViewHelper namespace configuration, so that
the debug viewhelpers weren't added/removed, depending on the value.

This commit makes the caches get flushed when the option is changed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Krzysztof Gutkowski uploaded patch set 1 06/15/23, 08:03

  2. core-ci voted on patch set 1 V +1 06/15/23, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42645

  3. Benni Mack commented on patch set 1 06/15/23, 10:29

    PreviewModule.php:280

    I suggest we use the cache group here.
  4. Krzysztof Gutkowski uploaded patch set 2 V +1 06/15/23, 12:32

  5. Krzysztof Gutkowski commented on patch set 2 06/15/23, 12:33

    PreviewModule.php:280 Reply

    Done
  6. core-ci voted on patch set 2 V +1 06/15/23, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42658

  7. Benni Mack voted on patch set 2 CR +1 07/04/23, 13:42

  8. Frank Nägler voted on patch set 2 V +1 CR +1 07/04/23, 19:36

  9. Benni Mack voted on patch set 2 V +2 CR +2 07/04/23, 19:55

  10. Benni Mack merged patch set 3 07/04/23, 19:55